Skip to content

[feature] code-first discriminated union API #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 59 commits into
base: main
Choose a base branch
from
Open

[feature] code-first discriminated union API #1073

wants to merge 59 commits into from

Conversation

DeagleGross
Copy link
Collaborator

@DeagleGross DeagleGross commented May 27, 2023 •
edited
Loading

Implemented code-first discriminated union generation as was described in feature request.

Several notes:

  1. implemented very straightforward diagnostics report. Please, let me know if we need more \ less \ modifications
    a) class is not marked with partial keyword
    b) unionName parameter of ProtoUnionAttribute<> is null or whitespace
    c) memberName parameter of ProtoUnionAttribute<> is null or whitespace
    d) fieldNumbers are not unique per full class
    e) memberNames are not unique per class
    f) namespace not found for a class (either standard or file-scoped namespace is supported)
  2. Tested functionality in E2E (using local nuget feed):

Here is confirmation that files are generated per union name
image

and small demo of reported diagnostics
DiscriminatedUnionDiagnostics

closes #1060

@DeagleGross
setup tests for code fixx
f96be49
@DeagleGross
refactor and make roslyn code fix to include protobuf packages
f64affe
@DeagleGross
prepare test infra for validating code-fix-provider
41c078c
@DeagleGross
more tests to understand the behavior
626d640
@DeagleGross
implement ShouldDeclareDefault_CodeFixProvider !
d30a549
@DeagleGross
remove decimal fromShouldDeclareDefault diagnostic
edf0622
@DeagleGross
refactor the diagnostic part on different scenarios
3f21150
@DeagleGross
make previous tests pass
0e3024a
@DeagleGross
split up tests
3c52ad8
@DeagleGross
more tests and fixes
db75431
@DeagleGross
add the constructor parameter equality checks
6bac117
@DeagleGross
refactor to use semantic model value
7154309
@DeagleGross
simplify and split up tests
cd7be72
@DeagleGross
and implement IsRequired
7037b7d
@DeagleGross
Merge branch 'main' into dmkorolev/default-values-analyzer
5082be1 
# Conflicts:
#	src/BuildToolsUnitTests/BuildToolsUnitTests.csproj
#	src/protobuf-net.BuildTools.Legacy/protobuf-net.BuildTools.Legacy.csproj
@DeagleGross
merge main & resolve conflicts
b27ea83
@DeagleGross
remove warnings
a6b4306
@DeagleGross
lightxunitverifier to fix glitch
4143f21
@DeagleGross
Revert "lightxunitverifier to fix glitch"
13f1af4 
This reverts commit 4143f21.
@DeagleGross
try use SemanticStructure validation only
9990564
@DeagleGross
validate using addition in a separate test + fix glitch
df87719
@DeagleGross
and fix last glitching test
4e26eb8
@DeagleGross
add tests for long syntax
697d1fa
@DeagleGross
try to parse in the way it is done by DefaultValue itself
f1a0e97
@DeagleGross
support long syntax + short syntax separately
eed17c0
@DeagleGross
make decimal work with long syntax for both short and long syntax
32d7159
@DeagleGross
use long syntax for other types as well (tests not working)
5641877
@DeagleGross
fix the converting issues in all flows + transfer nint and nuint …
9c43b25 
…to `IsRequired` scenario
@DeagleGross
init test + structure
4742e7c
@DeagleGross
checks
6e3486f
DeagleGross added 17 commits May 2, 2023 23:25
@DeagleGross DeagleGross requested a review from mgravell May 27, 2023 23:43
@DeagleGross DeagleGross self-assigned this May 27, 2023
@DeagleGross
Copy link
Collaborator Author

re 3: my fault - I did not pack protobuf-net.Core locally with new union attribute definition.
I will test locally, fix, and let you know when its ready to be reviewed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgravell mgravell Awaiting requested review from mgravell

Assignees

@DeagleGross DeagleGross

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposed code-first discriminated union API
2 participants
@DeagleGross @mgravell