You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds 2 DeserializeWithLengthPrefix method overloads to ProtoBuf.Serializer, with Type as first argument.
The new methods returns an object instead of <T>.
Sometimes developers do not have the generic T type argument, but instead they have a Type. Having this PR merged, will give developers the possibility to deserialize in those cases too.
The Serializer.NonGeneric API already exposes TryDeserializeWithLengthPrefix(...) which I think provides everything here - and there are multiple overloads under RuntimeTypeModel.Default.DeserializeWithLengthPrefix(...). If we do add anything extra: it should probably go on Serializer.NonGeneric, but honestly: I'm not sure we need an additional API here. Thoughts?
I have been using RuntimeTypeModel.Default.DeserializeWithLengthPrefix(...) for some time infact.
I just figured it would be a slight improvement in the Serializer API to expose the non-generic method too, instead of relying on a criptic "RuntimeTypeModel".
It would probably be better to include the non-generic methods in the Serializer.NonGeneric prop as you mentioned. If you wish, I can refactor the PR to include them there.
The TryDeserializeWithLengthPrefix(...) is not a good solution having just the Type and a Stream.
I would say, that having these 5 methods in Serializer.NonGeneric, it would be good to have the "**WithLengthPrefix" overloads paired with them.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds 2 DeserializeWithLengthPrefix method overloads to ProtoBuf.Serializer, with Type as first argument.
The new methods returns an object instead of <T>.
Sometimes developers do not have the generic T type argument, but instead they have a Type. Having this PR merged, will give developers the possibility to deserialize in those cases too.