-
Notifications
You must be signed in to change notification settings - Fork 2k
feat(cli): integrate D1 with "migrate diff" and "db pull" #23662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report 📦
|
Jolg42
reviewed
Apr 2, 2024
jkomyno
commented
Apr 2, 2024
Jolg42
reviewed
Apr 2, 2024
Jolg42
reviewed
Apr 2, 2024
Jolg42
approved these changes
Apr 2, 2024
Contributor
Jolg42
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 🙌🏼
jkomyno
commented
Apr 2, 2024
packages/migrate/src/__tests__/__snapshots__/MigrateDiff.test.ts.snap
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
--local-d1#23613In particular, it:
--from-local-d1and--to-local-d1boolean flags toprisma migrate diff. They locate the local Cloudflare D1 database automatically, if it exists.--local-d1boolean flag toprisma db pull. It locate the local Cloudflare D1 database automatically, if it exists.When
schema.prismaexists already, it overrides it. If the schema had no"driverAdapters"preview feature, the following warning is emitted:When no
schema.prismaexists, it generates it in./schema.prisma(rather than./prisma/schema.prisma, matching the same location used by--url), including agenerator clientblock with the"driverAdapters"preview feature.An introspected datasource looks like:
prisma migrate diffprisma db pullHow is a local Cloudflare D1 database located?
Let's see an example when using
migrate diff --from-local-d1:.wrangler/state/v3/d1/miniflare-D1DatabaseObject/<UUID>.sqlite..sqlitefile exists, the following error is emitted:.sqlitefiles exist, the following error are emitted:This logic is shared between
prisma migrate diffandprisma db pull, and lives inpackages/internals/src/utils/cloudflareD1.ts.