Skip to content

handle model deploy when no metrics to compare #1289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 18, 2024
Merged

handle model deploy when no metrics to compare #1289

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0574574
handle model deploy when no metrics to compare
ChuckHend Jan 17, 2024
667f68e
better warn msg
ChuckHend Jan 17, 2024
d0ff725
fix first run case
ChuckHend Jan 17, 2024
5831025
handle case where exists has no metrics
ChuckHend Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 41 additions & 23 deletions pgml-extension/src/api.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,37 +264,55 @@ fn train_joint(
);

let mut deploy = true;

match automatic_deploy {
// Deploy only if metrics are better than previous model.
// Deploy only if metrics are better than previous model, or if its the first model
Some(true) | None => {
if let Ok(Some(deployed_metrics)) = deployed_metrics {
let deployed_metrics = deployed_metrics.0.as_object().unwrap();
let deployed_metric = deployed_metrics
.get(&project.task.default_target_metric())
.unwrap()
.as_f64()
.unwrap();
info!(
"Comparing to deployed model {}: {:?}",
project.task.default_target_metric(),
deployed_metric
);
if project.task.value_is_better(
deployed_metric,
new_metrics
.get(&project.task.default_target_metric())
.unwrap()
.as_f64()
.unwrap(),
) {
if let Some(deployed_metrics_obj) = deployed_metrics.0.as_object() {
let default_target_metric = project.task.default_target_metric();
let deployed_metric = deployed_metrics_obj
.get(&default_target_metric)
.and_then(|v| v.as_f64());
info!(
"Comparing to deployed model {}: {:?}",
default_target_metric, deployed_metric
);
let new_metric = new_metrics.get(&default_target_metric).and_then(|v| v.as_f64());

match (deployed_metric, new_metric) {
(Some(deployed), Some(new)) => {
// only compare metrics when both new and old model have metrics to compare
if project.task.value_is_better(deployed, new) {
warning!(
"New model's {} is not better than current model. New: {}, Current {}",
&default_target_metric,
new,
deployed
);
deploy = false;
}
}
(None, None) => {
warning!("No metrics available for both deployed and new model. Deploying new model.")
}
(Some(_deployed), None) => {
warning!("No metrics for new model. Retaining old model.");
deploy = false;
}
(None, Some(_new)) => warning!("No metrics for deployed model. Deploying new model."),
}
} else {
warning!("Failed to parse deployed model metrics. Check data types of model metadata on pgml.models.metrics");
deploy = false;
}
}
}

Some(false) => deploy = false,
Some(false) => {
warning!("Automatic deployment disabled via configuration.");
deploy = false;
}
};

if deploy {
project.deploy(model.id, Strategy::new_score);
} else {
Expand Down