Skip to content

Conversation

@mark99i
Copy link
Contributor

@mark99i mark99i commented Dec 2, 2025

No description provided.

@mark99i
Copy link
Contributor Author

mark99i commented Dec 2, 2025

I don't think I've fully figured out how the dependencies for the tests are installed here

@ponytailer
Copy link
Owner

I don't think I've fully figured out how the dependencies for the tests are installed here

Maybe upgrade the pydantic version: pydantic -> pydantic-core -> pyo3

@ponytailer ponytailer self-requested a review December 3, 2025 05:08
@mark99i
Copy link
Contributor Author

mark99i commented Dec 3, 2025

I don't think I've fully figured out how the dependencies for the tests are installed here

Maybe upgrade the pydantic version: pydantic -> pydantic-core -> pyo3

rather, it's about uv.lock, I haven't figured it out yet
in the requirements, I specified pydantic 2.12.5 latest for now
I have checked the tests on windows python 3.14, everything is working

@ponytailer
Copy link
Owner

ponytailer commented Dec 3, 2025

I don't think I've fully figured out how the dependencies for the tests are installed here

Maybe upgrade the pydantic version: pydantic -> pydantic-core -> pyo3

rather, it's about uv.lock, I haven't figured it out yet in the requirements, I specified pydantic 2.12.5 latest for now I have checked the tests on windows python 3.14, everything is working

The update to the requirements is solely for testing purposes. The version of pydantic that pydantic-client depends on does not support Python 3.14. Therefore, during the CI build process, we first use uv sync to set up the project environment. If we want to support Python 3.14, the version of pydantic that the project itself depends on must also be updated.
Remove pydantic from requirements.txt and update it to pyproject.toml.

BTW, remove statsd too.

@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.90%. Comparing base (542717f) to head (9a5b3b7).
⚠️ Report is 1 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #158      +/-   ##
==========================================
+ Coverage   89.45%   89.90%   +0.45%     
==========================================
  Files           8        8              
  Lines         493      515      +22     
==========================================
+ Hits          441      463      +22     
  Misses         52       52              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mark99i
Copy link
Contributor Author

mark99i commented Dec 4, 2025

I do not know why, but some of the dependencies on windows in CI do not install the latest versions, although I check manually on windows and there are no problems

ERROR: Ignored the following versions that require a different python version: 7.0.0 Requires-Python >=3.10.0
ERROR: Could not find a version that satisfies the requirement isort==7.0.0 (from versions: 1.0.0, 1.0.1, 1.2.0, 1.2.2, 1.2.3, 1.2.5, 1.3.0, 1.3.1, 1.3.2, 2.0.0, 2.0.1, 2.1.0, 2.2.0, 2.2.1, 2.3.0, 2.4.0, 2.4.1, 2.5.0, 2.6.0, 2.6.1, 2.6.2, 2.6.3, 3.0.0, 3.1.0, 3.1.1, 3.1.2, 3.2.0, 3.3.0, 3.3.1, 3.4.0, 3.4.1, 3.4.2, 3.5.0, 3.6.0, 3.6.1, 3.6.2, 3.7.0, 3.7.1, 3.7.2, 3.8.0, 3.8.1, 3.8.2, 3.8.3, 3.9.0, 3.9.1, 3.9.2, 3.9.3, 3.9.4, 3.9.5, 3.9.6, 4.0.0, 4.1.0, 4.1.1, 4.1.2, 4.2.0, 4.2.1, 4.2.2, 4.2.3, 4.2.4, 4.2.5, 4.2.8, 4.2.9, 4.2.11, 4.2.12, 4.2.13, 4.2.14, 4.2.15, 4.3.0, 4.3.1, 4.3.2, 4.3.3, 4.3.4, 4.3.5, 4.3.6, 4.3.7, 4.3.8, 4.3.9, 4.3.10, 4.3.11, 4.3.12, 4.3.13, 4.3.14, 4.3.15, 4.3.16, 4.3.17, 4.3.18, 4.3.19, 4.3.20, 4.3.21, 5.0.0, 5.0.1, 5.0.2, 5.0.3, 5.0.4, 5.0.5, 5.0.6, 5.0.7, 5.0.8, 5.0.9, 5.1.0, 5.1.1, 5.1.2, 5.1.3, 5.1.4, 5.2.0, 5.2.1, 5.2.2, 5.3.0, 5.3.1, 5.3.2, 5.4.0, 5.4.1, 5.4.2, 5.5.0, 5.5.1, 5.5.2, 5.5.3, 5.5.4, 5.5.5, 5.6.0, 5.6.1, 5.6.2, 5.6.3, 5.6.4, 5.7.0, 5.8.0, 5.9.0, 5.9.1, 5.9.2, 5.9.3, 5.10.0, 5.10.1, 5.11.0, 5.11.1, 5.11.2, 5.11.3, 5.11.4, 5.11.5, 5.12.0, 5.13.0, 5.13.1, 5.13.2, 6.0.0a1, 6.0.0b1, 6.0.0b2, 6.0.0, 6.0.1, 6.1.0)
ERROR: No matching distribution found for isort==7.0.0

https://github.com/ponytailer/pydantic-client/actions/runs/19913293823/job/57086658651

Remove pydantic from requirements.txt and update it to pyproject.toml.
BTW, remove statsd too.

if I delete them, then pip install -r requirements.txt won't install them, and I'll have to install them manually.
That's why I added them there.

@ponytailer ponytailer merged commit bf52ff4 into ponytailer:main Dec 9, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants