Skip to content

Update external image renderer engine defaults #5287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jdbeel
Copy link

@jdbeel jdbeel commented Jul 21, 2025

Code PR

  • I have read through the contributing notes and understand the structure of the package. In particular, if my PR modifies code of plotly.graph_objects, my modifications concern the code generator and not the generated files.
  • I have added tests or modified existing tests.
  • For a new feature, I have added documentation examples (please see the doc checklist as well).
  • I have added a CHANGELOG entry if changing anything substantial.
  • For a new feature or a change in behavior, I have updated the relevant docstrings in the code.

@jdbeel
Copy link
Author

jdbeel commented Jul 21, 2025

Fixes the issue in #5286

I don't believe any docstrings need updating as the ones for the classes/methods I changed do not reference the default for the engine argument. The default was also changed to None further up the API. I believe this should basically be a NOP for most users/flows. If this warrants a change in the CHANGELOG, please let me know. I figured for the above reasons it did not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant