Replace country-regex with i18n-iso-countries #7366
+29
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks @dimitrov570 - I'll see if we can get this into the 3.1 release. |
camdecoster
approved these changes
Jul 30, 2025
There was a problem hiding this comment.
Thanks for your contribution! I left a few comments. Could you please merge master and handle the merge conflicts?
@gvwilson there are 6 codes removed from the new package. Would this count as a breaking change? The countries don't exist anymore.
| Code | Country |
|---|---|
| ANT | Netherlands Antilles |
| CSK | Czechoslovakia |
| DDR | German Democratic Republic |
| EAZ | Zanzibar |
| YMD | South Yemen |
| YUG | Yugoslavia |
| @@ -0,0 +1 @@ | |||
| - Replace country-regex with i18n-iso-countries [[#7366](https://github.com/plotly/plotly.js/pull/7366)] | |||
There was a problem hiding this comment.
Suggested change
| - Replace country-regex with i18n-iso-countries [[#7366](https://github.com/plotly/plotly.js/pull/7366)] | |
| - Replace country-regex package with i18n-iso-countries [[#7366](https://github.com/plotly/plotly.js/pull/7366)] |
| @@ -12,8 +11,8 @@ var isPlainObject = require('./is_plain_object'); | |||
| var nestedProperty = require('./nested_property'); | |||
| var polygon = require('./polygon'); | |||
|
|
|||
| // make list of all country iso3 ids from at runtime | |||
| var countryIds = Object.keys(countryRegex); | |||
| const countries = require("i18n-iso-countries"); | |||
There was a problem hiding this comment.
Could you please move this require statement above with the others?
|
I don't think the deleted countries counts as a breaking change. |
|
I clicked the wrong button. Let me know when you make changes and I'll review again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves the issue discussed in #7026.
This implementation does not use regular expressions as before and does not contain countries that do not exist anymore, compared to the previous solution with
country-regex. But on the other handi18n-iso-countriesseems to be updated frequently, so it will contain updated information on country codes.