perf: faster sanitize date #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

ayrton merged 2 commits into planetscale:main from andrewvasilchuk:andrewvasilchuk-patch-1

Dec 14, 2023

Contributor

andrewvasilchuk commented Aug 5, 2023

Use String#slice instead of String#replace since it is ~20% faster in this particular case according to this performance test.


          perf: faster sanitize date

Use `String#slice` instead of `String#replace` since it is ~15% faster in this particular case

Contributor

iheanyi commented Aug 14, 2023

Going to close this one out. We only want to use replace in the sense that if the Z exists at the end, remove it. With this change, we're losing precision if the string doesn't contain the timezone.

iheanyi closed this

Contributor Author

andrewvasilchuk commented Aug 14, 2023

@iheanyi thanks for the feedback. Following MDN Date.prototype.toISOString() and ECMAScript Language Specification, a date string, returned from the Date#toISOString method always contain a "Z" char at the end.

Contributor

iheanyi commented Aug 14, 2023 •

edited

Loading

Good point, that's a good call then. I'll reopen this then

iheanyi reopened this


          Merge branch 'main' into andrewvasilchuk-patch-1

3435fd8

ayrton enabled auto-merge

December 14, 2023 13:03

Contributor

ayrton commented Dec 14, 2023

Thank you

ayrton approved these changes

View reviewed changes

ayrton merged commit 1c02bdf into planetscale:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet