Fix order of values popped from the operand stack #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

m3m0r7 merged 1 commit into php-java:master from y-uti:fix-operand-order

Apr 4, 2019

Contributor

y-uti commented Apr 4, 2019

In binary operations such as iadd, isub, etc., the order of values popped from the operand stack is wrong. It should be right-to-left order. This PR will do:

fix implementations of those instructions
add test cases for integer arithmetics, logicals, and branches


          Fix order of values stored in the operand stack

68335b3

Member

m3m0r7 commented Apr 4, 2019

@y-uti
Thank you for your contribution to this project!

m3m0r7 merged commit cb95f98 into php-java:master

y-uti deleted the fix-operand-order branch

April 5, 2019 12:48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet