Deprecate xml simple config #256
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehuelsmann
commented
Feb 1, 2025
| - name: filesize_cap | ||
| class: MyApp::Validator::FileSizeCap | ||
| param: | ||
| - name: max_size |
There was a problem hiding this comment.
Would have been nice to have had a hash instead of an array. Are we too far on the 2.x release line?
param:
max_size: 20MThinking about the options: maybe we can support both arrays (of hashes with the name/value keys) and plain hashes?
There was a problem hiding this comment.
Sound like a path if we do as you suggest, then we could phase out plain hashes with 3.0, but allow for both in 2.X - if I understand your comment correctly
Pull Request Test Coverage Report for Build 13091927006Details
💛 - Coveralls |
ehuelsmann
commented
Feb 1, 2025
| action: | ||
| - name: CreateUser | ||
| class: MyApp::Action::CreateUser | ||
| field: |
There was a problem hiding this comment.
Same comment as with the validator parameters above. Would have been much nicer to have;
username:
is_required: yes
email:
is_required: yes|
@jonasbn I think this is the documentation you were referring to? |
jonasbn
approved these changes
Apr 30, 2025
|
@ehuelsmann let me know if you have any additional questions or comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deprecate XML: Warn when used and replace documentation with YAML instead of XML
Closes #125
Type of change
Please delete options that are not relevant.
Checklist: