Bump Redux version to 5.0.0 #292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hey @elamperti, thanks for the PR. I'm traveling, but will take a look as soon as possible. |
added 2 commits
December 27, 2023 13:58
pburtchaell
approved these changes
Dec 27, 2023
Owner
|
Hey @elamperti, just merged this to master, bumped version to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting an issue, please:
✔️ Agree the Code of Conduct.
✔️ Read the Contributing Guide.
Checklist
Before submitting a pull request, please make sure the following is done:
I haven't added new tests.
Tests pass successfully after installing the upgraded package.
The contributing guide suggest syncing the yarn lockfile and the npm lockfile, yet the script mentioned (
generate-lockfile) is not present. Given that the repo doesn't have ayarn.lockeither, I'm not sure how to proceed with this. I was able to generate an updated lockfile with the new Redux version though.Changes
bincommand anymore (since v9), so many of the scripts using it didn't work. I've removed all uses ofnpm bininpackage.json.(and I didn't bump the package version, so this is not ready for a release)
Let me know if I need to make any adjustments.