Fix: Validate Agent name to reject empty string and None #1144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you so much for sending this! but we've been already working with a different contributor for this at #998; sharing your insights on the PR reviews instead would be appreciated. Thanks again for your interest and time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds strict validation to the Agent class to ensure the name parameter meets the expected requirements:
If name is set to None, an exception (ValueError) is now raised.
If an empty string ("") or a whitespace-only string is passed, a ValueError is also raised.
Although type hints specify that name should be of type str, previously the constructor allowed invalid values such as None or empty strings at runtime, leading to potential issues during agent registration, logging, and debugging.
With this fix:
Agents must always have a meaningful, non-empty name.
Prevents silent errors and ensures better reliability and consistency in multi-agent workflows.
Improves clarity during logging, debugging, and runtime identification of agents.
This validation strictly enforces correct usage, reducing potential misuse of the SDK.