-
-
Notifications
You must be signed in to change notification settings - Fork 11.1k
BUG: Allow reading non-npy files in npz and add test #29313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Retrieving `a` from an npz file will first check for a file `a`, then for `a.npy`; this checks both.
DWesl
commented
Jul 2, 2025
seberg
reviewed
Jul 4, 2025
Otherwise it complains it isn't already a ZIP archive
Old behavior is to read everything, which will happen if I pass no argument.
seberg
approved these changes
Jul 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the follow up and test. I don't see a reason to still consider it a draft, let's get it in.
charris
pushed a commit
to charris/numpy
that referenced
this pull request
Jul 22, 2025
* TST: Add test for non-npy files in npz and different names Retrieving `a` from an npz file will first check for a file `a`, then for `a.npy`; this checks both. * BUG: Argument to read should be int not str Old behavior is to read everything, which will happen if I pass no argument. --------- Co-authored-by: Sebastian Berg <sebastian@sipsolutions.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retrieving
a
from an npz file will first check for a filea
, then fora.npy
; this checks both.Fixes #29282