forked from javascript-tutorial/en.javascript.info
-
Notifications
You must be signed in to change notification settings - Fork 2
merge changes #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👾 just add missed break line
✅ fixed a typo
Update about.md (change "data" field to "value")
⚡ placed missed break lines and remove extra
Fixed setTimeout() issue
Fix typo in text
Update article.md
Clarify confusing point
Fix grammar and phrasing
add commas
minor fixes
Date task solution: use standard date time string
differ should be differentiate https://developer.mozilla.org/en-US/search is broken so I changed it to https://developer.mozilla.org/en-US/ Other language changes are to improve readability and correct minor language errors
Fix language errors and fix broken link
Unicode art, grammar suggestions
The event type for `onerror()` is a vanilla `Event` that has no `message` property (or anything interesting about the error). Further info from this StackOverflow question: [Javascript doesn't catch error in WebSocket instantiation](https://stackoverflow.com/questions/31002592/javascript-doesnt-catch-error-in-websocket-instantiation/31003057#31003057).
http to https checked links
Remove use of error.message in onerror()
Content-Length is now a CORS-safelisted response header
strict-origin-when-cross-origin is now the default referrerPolicy
typo at String concatenation with binary
Remove a redundant argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.