module: correctly detect top-level await in ambiguous contexts #58646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #58646 +/- ##
==========================================
+ Coverage 90.10% 90.11% +0.01%
==========================================
Files 640 640
Lines 188493 188431 -62
Branches 36971 36965 -6
==========================================
- Hits 169843 169808 -35
+ Misses 11358 11342 -16
+ Partials 7292 7281 -11
🚀 New features to boost your workflow:
|
addaleax
reviewed
Jun 9, 2025
Ethan-Arrowood
approved these changes
Jun 10, 2025
Collaborator
joyeecheung
reviewed
Jun 15, 2025
Ethan-Arrowood
approved these changes
Jun 16, 2025
Collaborator
jasnell
reviewed
Jun 21, 2025
src/node_contextify.cc
Outdated
| std::array<std::string_view, 2>{// example: `func(await 1);` | ||
| "missing ) after argument list", | ||
| // example: `if(await 1)` | ||
| "SyntaxError: Unexpected"}; |
Member
There was a problem hiding this comment.
Did the linter/formatter format the code this way?
Member
Author
There was a problem hiding this comment.
Yes, but now that you mention it, it's a weird format.
I've changed the comment's position.
Member
Author
There was a problem hiding this comment.
@jasnell
Could you take another look when you have a moment?
jasnell
approved these changes
Jun 21, 2025
joyeecheung
reviewed
Jun 27, 2025
Member
joyeecheung
left a comment
There was a problem hiding this comment.
Can you add some tests to ensure that unrelated errors stays the same? For example, when it's const foo bar (which is supposed to throw SyntaxError: Unexpected identifier 'bar') or console.log('PI: ' Math.PI); (which is supposed throw missing ) after argument list).
Member
Author
|
I added several tests to confirm that unrelated errors are not affected by top-level await. |
jasnell
approved these changes
Jun 29, 2025
joyeecheung
reviewed
Jun 30, 2025
test/es-module/test-esm-tla-syntax-errors-not-recognized-as-tla-error.mjs
Outdated
Show resolved
Hide resolved
…a-error.mjs Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
joyeecheung
approved these changes
Aug 12, 2025
Collaborator
Ethan-Arrowood
approved these changes
Aug 13, 2025
Collaborator
Collaborator
|
Landed in 360f7cc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #58331
Many syntax errors are incorrectly treated as requiring ESM recompilation, but since they can't be clearly distinguished from top-level await-related errors, the current fix ends up handling them together.
From what I can tell by looking at the issues reported on V8, this appears to be a problem on the V8 side, so I will see if a fix can be made there.
https://issues.chromium.org/issues/40070895#comment1
That said, this patch will be necessary until the issue is resolved in V8.