Skip to content

module: integrate TypeScript into compile cache #56629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 4 commits into from
Jan 25, 2025
Merged

module: integrate TypeScript into compile cache #56629

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
16fd566
module: integrate TypeScript into compile cache
joyeecheung Jan 7, 2025
a3fbc72
fixup! module: integrate TypeScript into compile cache
joyeecheung Jan 20, 2025
6bc4178
fixup! fixup! module: integrate TypeScript into compile cache
joyeecheung Jan 22, 2025
a5624ce
fixup! fixup! fixup! module: integrate TypeScript into compile cache
joyeecheung Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! fixup! module: integrate TypeScript into compile cache
  • Loading branch information
@joyeecheung
joyeecheung committed Jan 22, 2025
commit 6bc4178b019c6b5f1a5136e2c3008c313717e874
3 changes: 2 additions & 1 deletion src/node_modules.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ namespace modules {

using v8::Array;
using v8::Context;
using v8::External;
using v8::FunctionCallbackInfo;
using v8::HandleScope;
using v8::Integer;
Expand Down Expand Up @@ -565,7 +566,7 @@ void SaveCompileCacheEntry(const FunctionCallbackInfo<Value>& args) {
CHECK(args[0]->IsExternal());
CHECK(args[1]->IsString()); // TODO(joyeecheung): accept buffer.
auto* cache_entry =
static_cast<CompileCacheEntry*>(args[0].As<v8::External>()->Value());
static_cast<CompileCacheEntry*>(args[0].As<External>()->Value());
Utf8Value utf8(isolate, args[1].As<String>());
env->compile_cache_handler()->MaybeSave(cache_entry, utf8.ToStringView());
}
Expand Down
Loading