Mark all the unknown achievements as done and remove the survey one during the installation #2816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

lesleyjanenorton merged 3 commits into main from achievements

Oct 28, 2025

Collaborator

bakulf commented Oct 28, 2025

This patch does the following:

during the installation, it removes the "survey" survey if found in the list of achievements
when we are about to show a panel, let's choose the right achievement based on a list, and let's mark all the others as done to avoid extra computation the next time the panel is opened.


          Mark all the unknown achievements as done and remove the survey one d…

f377174

…uring the installation

bakulf requested a review from lesleyjanenorton

October 28, 2025 13:58

bakulf added 2 commits

October 28, 2025 14:59


          8.3.4 version bump

1406ad3


          Fix a typo

0cf1e14

lesleyjanenorton approved these changes

View reviewed changes

Collaborator

lesleyjanenorton left a comment

👍

lesleyjanenorton merged commit f0274d1 into main

2 checks passed

dannycolin linked an issue

that may be closed by this pull request

Achievement "100 Tabs" shows every time the addon panel is opened #2813

Closed

2 tasks

dannycolin mentioned this pull request

Achievement "100 Tabs" shows every time the addon panel is opened #2813

Closed

2 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet