chore: Enable proxy for OIDC and MongoDB connections MCP-88 #405
+22
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By providing { useEnvironmentVariableProxies: true }
the NodeDriverServiceProvider already reads the relevant
environment variables and sets up the proxy internally.
Pull Request Test Coverage Report for Build 16571265217Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
blva
reviewed
Jul 28, 2025
Mentioning that it supports the same behaviour as mongosh.
|
@kmruiz does this need to be in a feature branch? does it need other PRs to become feature complete? (not blocking just wondering) Note: looking at the code seems self contained enough. |
|
@fmenezes The auto-merged did it's work too early :D. It's self-contained, it can be even released if we want to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
By providing { useEnvironmentVariableProxies: true } the NodeDriverServiceProvider already reads the relevant environment variables and sets up the proxy internally.
This is as specified in the section
Setting up the proxy for NodeDriverServiceProvider (MongoDB + OIDC)from the Technical Design.Checklist