Skip to content

chore(tests): use the newer @vitest/eslint-plugin package #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025

Conversation

gagik
Copy link
Collaborator

@gagik gagik commented Jul 15, 2025

The eslint config was using the older naming for the vitest eslint plugin which also had outdated dependencies. This fixes that.

The eslint config was using the older naming for the vitest eslint plugin which also had autodated dependencies. This fixes that.
@Copilot Copilot AI review requested due to automatic review settings July 15, 2025 15:00
@gagik gagik requested a review from a team as a code owner July 15, 2025 15:00
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the ESLint configuration to use the newer @vitest/eslint-plugin package in place of the deprecated eslint-plugin-vitest.

  • Remove old eslint-plugin-vitest dependency and add @vitest/eslint-plugin in package.json
  • Update import path in eslint.config.js to reference the new plugin package

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
package.json Removed eslint-plugin-vitest and added @vitest/eslint-plugin dependency
eslint.config.js Changed import from eslint-plugin-vitest to @vitest/eslint-plugin

@gagik gagik enabled auto-merge (squash) July 15, 2025 15:06
@coveralls
Copy link
Collaborator

coveralls commented Jul 15, 2025

Pull Request Test Coverage Report for Build 16296888938

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 8 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 77.39%

Changes Missing Coverage Covered Lines Changed/Added Lines %
eslint.config.js 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
src/tools/atlas/connect/connectCluster.ts 8 70.7%
Totals Coverage Status
Change from base Build 16294764740: -0.2%
Covered Lines: 2828
Relevant Lines: 3611

💛 - Coveralls

@gagik gagik merged commit f44057b into main Jul 15, 2025
22 of 24 checks passed
@gagik gagik deleted the gagik/fix-eslint-warning branch July 15, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants