fix: atlas connection keeps reconnecting #373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR prevents the client from repeatedly disconnecting when the Atlas cluster status is unknown, which was causing a reconnect loop.
- Group the
unknownstate withconnectingso it no longer falls through to the default disconnect logic - Removed the standalone
case "unknown":under the disconnect branch - No tests were added to verify the new handling of
unknownstatus
Comments suppressed due to low confidence (1)
src/tools/atlas/connect/connectCluster.ts:214
- Add or update unit tests to cover the 'connecting' and 'unknown' cases to ensure the client does not reconnect unexpectedly and to prevent regressions.
case "connecting":
| @@ -211,12 +211,12 @@ export class ConnectClusterTool extends AtlasToolBase { | |||
| ], | |||
| }; | |||
| } | |||
| case "connecting": { | |||
| case "connecting": | |||
| case "unknown": { | |||
There was a problem hiding this comment.
Consider logging when the status is 'unknown' so that developers can trace when and why the cluster enters this state, instead of silently ignoring it.
Suggested change
| case "unknown": { | |
| case "unknown": { | |
| logger.warn( | |
| LogId.atlasUnknownState, | |
| "atlas-connect-cluster", | |
| `Cluster "${clusterName}" in project "${projectId}" entered an unknown state.` | |
| ); |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
no need, this is just a missed db ping
blva
approved these changes
Jul 15, 2025
Pull Request Test Coverage Report for Build 16294515117Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fix atlas connection keeps reconnecting
Checklist