Skip to content

Fix open handles detected by jest #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

royderks
Copy link

Motivation and Context

Fix open handles as detected when running jest:

Before:

A worker process has failed to exit gracefully and has been force exited. This is likely caused by tests leaking due to improper teardown. Try running with --detectOpenHandles to find leaks. Active timers can also cause this, ensure that .unref() was called on them.

This fixes 3/4 open handles, the 4th open handles requires more fixes to be added to the way the stdio.ts transport type handles stdin

How Has This Been Tested?

Tested

Breaking Changes

None

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@royderks royderks requested a review from a team as a code owner July 25, 2025 22:42
@royderks royderks requested a review from ihrpr July 25, 2025 22:42
@royderks royderks force-pushed the fix-jest-open-handles branch from 6b80f4f to 905a4d7 Compare July 25, 2025 22:44
@royderks royderks force-pushed the fix-jest-open-handles branch from 905a4d7 to 57d9d44 Compare July 25, 2025 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant