Allow enum in registerPrompt argsSchema #710
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
sunrabbit123
pushed a commit
to sunrabbit123/typescript-sdk
that referenced
this pull request
Jun 30, 2025
Added optional _meta field to ResourceContentsSchema, PromptSchema, and EmbeddedResourceSchema to align with spec change PR modelcontextprotocol#710. These were the only schemas missing the _meta field that were required by the specification update. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
|
Thank you for splitting #691. Sorry, I need to close this one for now as it breaks spec compliance. The issue: PR #729 will introduce compile-time type checking between SDK and spec types. This changes would cause these checks to fail:
The spec defines GetPromptRequest.params.arguments as Record<string, string>. This PR changes it to accept a union type that includes enum objects, which diverges from the spec. Our policy is to maintain strict type compatibility with the MCP specification. Any changes to the type system need to:
If Enum changes in the spec are approved, we can implement it here as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Being able to take user input that is enumerated values is useful when creating prompt callback functions and allows deeper prompt argument validation. Zod enum enforce a fixed set of strings at the SDK layer while still sending strings to the spec.
How Has This Been Tested?
Unit test coverage added
Breaking Changes
No breaking changes, backwards compatibility is maintained
Types of changes
Checklist
Additional context
Follow up to #691 with enum only. Spec changes will be needed to support other Zod schema types, such as boolean, as the spec currently only supports strings.