fix: enable inline parsing of content with marked v13+ #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

jayree wants to merge 1 commit into mikaelbr:master from jayree:fix/list-item-formatting-marked-v13

jayree commented Apr 3, 2025 •

edited

Loading

fixes #304


          fix: enable inline parsing of content with marked v13+

1bad9bb

bolinfest mentioned this pull request

fix: patch in #366 and #367 for marked-terminal openai/codex#916

Merged

bolinfest added a commit to openai/codex that referenced this pull request


          fix: patch in #366 and #367 for marked-terminal (#916)

1ff3e14

This PR uses [`pnpm
patch`](https://www.petermekhaeil.com/til/pnpm-patch/) to pull in the
following proposed fixes for `marked-terminal`:

* mikaelbr/marked-terminal#366
* mikaelbr/marked-terminal#367

This adds a substantial test to `codex-cli/tests/markdown.test.tsx` to
verify the new behavior.

Note that one of the tests shows two citations being split across a line
even though the rendered version would fit comfortably on one line.
Changing this likely requires a subtle fix to `marked-terminal` to
account for "rendered length" when determining line breaks.

agentydragon pushed a commit to agentydragon/codex that referenced this pull request


          fix: patch in openai#366 and openai#367 for marked-terminal (openai#916)

b2a4531

This PR uses [`pnpm
patch`](https://www.petermekhaeil.com/til/pnpm-patch/) to pull in the
following proposed fixes for `marked-terminal`:

* mikaelbr/marked-terminal#366
* mikaelbr/marked-terminal#367

This adds a substantial test to `codex-cli/tests/markdown.test.tsx` to
verify the new behavior.

Note that one of the tests shows two citations being split across a line
even though the rendered version would fit comfortably on one line.
Changing this likely requires a subtle fix to `marked-terminal` to
account for "rendered length" when determining line breaks.

UziTech approved these changes

View reviewed changes

xierenyuan mentioned this pull request

fix: patch marked-terminal to handle nested list items correctly neovateai/neovate-code#135

Merged

buihongduc132 pushed a commit to buihongduc132/codex that referenced this pull request


          fix: patch in openai#366 and openai#367 for marked-terminal (openai#916)

1e5d59d

This PR uses [`pnpm
patch`](https://www.petermekhaeil.com/til/pnpm-patch/) to pull in the
following proposed fixes for `marked-terminal`:

* mikaelbr/marked-terminal#366
* mikaelbr/marked-terminal#367

This adds a substantial test to `codex-cli/tests/markdown.test.tsx` to
verify the new behavior.

Note that one of the tests shows two citations being split across a line
even though the rendered version would fit comfortably on one line.
Changing this likely requires a subtle fix to `marked-terminal` to
account for "rendered length" when determining line breaks.

UziTech mentioned this pull request

Render inline styles in list items #372

Open

Contributor

UziTech commented Oct 7, 2025

@mikaelbr can we get this merged?

hyperz111 added a commit to hyperz111/marked-terminal that referenced this pull request


          mikaelbr#366

876a984

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet