Improve sizeclass calculation #777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

mjp41 merged 1 commit into microsoft:main from mjp41:sizeclass

Jul 1, 2025

Member

mjp41 commented Jul 1, 2025

This makes two changes:

It makes the 64k sizeclass a small sizeclass rather than a large sizeclass
It uses consistent guards across determining if something is a small sizeclass to improve codegen on MSVC.

mjp41 force-pushed the sizeclass branch 2 times, most recently from 9dd910a to d1758f0 Compare

July 1, 2025 09:30


          Small sizeclass lookup improvement,

c8e6ec0

* Fix off by one in deciding where to switch from small to large.
* Improve codegen on Windows by making it simpler for compiler to remove a redundant branch

mjp41 force-pushed the sizeclass branch from d1758f0 to c8e6ec0 Compare

July 1, 2025 10:03

mjp41 merged commit 012138e into microsoft:main

79 checks passed

mjp41 deleted the sizeclass branch

July 1, 2025 11:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet