Further gcc -Werror=array-bounds fix #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

nwf merged 1 commit into microsoft:main from nwf:202409-gcc-startup

Sep 21, 2024

Contributor

nwf commented Sep 21, 2024

In test/perf/startup, gcc (Debian 14.2.0-3) seems to get confused about the size of the counters vector as the code was written. Rewrite the code to pass the same value (std::thread::hardware_concurrency(), but in a local) to both counters.resize() and the ParallelTest ctor.


          Further gcc -Werror=array-bounds fix

2ed0f92

In test/perf/startup, gcc (Debian 14.2.0-3) seems to get confused about
the size of the counters vector as the code was written.  Rewrite the
code to pass the same value (`std::thread::hardware_concurrency()`, but
in a local) to both `counters.resize()` and the `ParallelTest` ctor.

nwf requested a review from mjp41

September 21, 2024 03:41

mjp41 approved these changes

View reviewed changes

Member

mjp41 left a comment

Not sure how that fixes GCC warning, but the code looks the same, so looks fine to me.

nwf merged commit 1925909 into microsoft:main

nwf deleted the 202409-gcc-startup branch

September 21, 2024 10:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet