Made pool reuse a queue #612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwf-msr
approved these changes
Apr 25, 2023
Contributor
nwf-msr
left a comment
There was a problem hiding this comment.
Nits, but it sounds like a good plan to me.
src/snmalloc/mem/pool.h
Outdated
| PoolState<T>& pool = get_state(); | ||
| last->next = nullptr; | ||
| FlagLock f(pool.lock); | ||
| // Pushes a linked list of objects onto the stack. Used to put a linked |
Contributor
There was a problem hiding this comment.
Probably just drop this comment, given the doxygen comment on the method?
So allocator churn will cause remote queues to be visited.
mjp41
added a commit
to mjp41/snmalloc
that referenced
this pull request
Apr 10, 2025
The pool sort routine is used by Verona's systematic testing. There was a bug introduced in microsoft#612 that could corrupt the list when a sort occured. This is not used by snmalloc and the test coverage was insufficient to expose the bug. This PR fixes the bug, and improves test coverage.
Merged
mjp41
added a commit
that referenced
this pull request
Apr 10, 2025
The pool sort routine is used by Verona's systematic testing. There was a bug introduced in #612 that could corrupt the list when a sort occured. This is not used by snmalloc and the test coverage was insufficient to expose the bug. This PR fixes the bug, and improves test coverage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So allocator churn will cause remote queues to be visited.