usb-device-hid: Fix boot protocol config in descriptor, default protocol mode, and protocol mode recover. #1036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subclass in HID interface descriptor is a flag of boot protocol support. Set it according to the interface protocol settings. HID devices should come up in non-boot mode according to Device Class Definition for Human Interface Devices (HID) v1.11 Appendix F.5. Set the initial state of interface protocol to report protocol. Signed-off-by: Hyx <hyx0329@outlook.com>
So HID device will exit boot protocol mode when entering normal OS. Signed-off-by: Hyx <hyx0329@outlook.com>
e89d0d9 to
7f8899d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the subclass value of the HID interface descriptor according to the supported interface protocol specified. Therefore BIOS will enumerate the keyboard.
The default interface protocol is set to report protocol according to the specification.
Since BIOS doesn't depend on the HID report descriptor, reset the device to report protocol when the report descriptor is read.
This is tested with a laptop and a RP2040 board with mpy 1.25.0 official release.
I use this to implement a NKRO keyboard with boot protocol support.
My understanding of 2 protocols: