Skip to content

Add datetime test for ax.violin #30384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add datetime test for ax.violin #30384

wants to merge 1 commit into from
+23 −3

Conversation

dstansby
Copy link
Member

@dstansby dstansby commented Aug 3, 2025

PR summary

Part of #26864. violin() seems to work fine, but the positions argument does not work at the moment - it's not immediately obvious to me if it should, so I left a TODO ending with a question mark in the test.

Replaces #27486.

PR checklist

@timhoffm
Copy link
Member

timhoffm commented Aug 4, 2025

positions should support dates so that you can easily do something like this: https://onepager.togaware.com/violin-plot.html#violin-plot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
topic: units and array ducktypes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dstansby @timhoffm