DOC: Simplify Line, Poly and RegularPoly example #30383
Conversation
- use `color` kwarg instead of separate `add_color()` - remove `autolim=True` from `add_collection()` calls as that is the default anyway
| # Note: the first argument to the collection initializer | ||
| # must be a list of sequences of (x, y) tuples; we have only | ||
| # one sequence, but we still have to put it in a list. |
There was a problem hiding this comment.
This note is out of place it refers to LineCollection([spiral], ..., but I claim this is enough of a standard pattern that we don't need to mention it.
| # autolim=True enables autoscaling. For collections with | ||
| # offsets like this, it is neither efficient nor accurate, | ||
| # but it is good enough to generate a plot that you can use | ||
| # as a starting point. If you know beforehand the range of | ||
| # x and y that you want to show, it is better to set them | ||
| # explicitly, set the *autolim* keyword argument to False. |
There was a problem hiding this comment.
This is unclear: Why is it neither efficient nor accurate. I'm also not clear whether the statement is still correct. It's from 2006 and collection limit handling as improved since then. If anything we'd need an explicit discussion on limit handling for collections, but that's not the scope of this example. So let's remove this here.
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
|
Manual backport is not worth the effort. |
colorkwarg instead of separateadd_color()autolim=Truefromadd_collection()calls as that is the default anyway