Fix legend labelcolor=‘linecolor’ to handle various corner cases, e.g. step histograms and transparent markers
#30328
Conversation
…o `linecolor`, e.g. ensuring that histograms with `step` histtype do not end up with an empty label
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
…m `c, fc` to `mfc, fc, mec, ec, c`; check if `color` is empty, `none` or transparent and loop on if so
…ne` for both `c` and `ec` to ensure invisibility, in classic black edges are default
|
Nice work @lukashergt ! The tests are really helpful and good. Glad it was fixed by u :) U deserve the credit. |
Using helper for `'none'` string equality and using the fact that `to_rgba` always returns a 4-element tuple to simplify the code. Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
…ble handles; can pass empty string `" "` to achieve empty/invisible label instead; having a black legend label by default allows the creation of neutrally coloured dummy entries
|
I'm pretty sure the current test failure has nothing to do with this PR. Some check timed out. If I could, I would simply try to re-run that test. Anything else that I should be doing, @timhoffm? |
|
The test failure is unrelated. From my perspective, you don't have to do anything. We just have to wait for a second reviewer approval. |
PR summary
This PR addresses issue #30298, which pointed out some corner cases, where
labelcolor='linecolor'did not work as expected, e.g.:histtype='step'or scatter plots withfc='none'had an empty legend label.mecandmfcbut notcwould end up with non-matching handle and label colours.The failing checks in this test from commit dabaf62 highlight the issue.
Changes:
'linecolor'ordering of checks fromc, fctomfc, fc, mec, ec, c.coloris empty, equal tononeor with a zero alpha value, e.g. whenfcis'none'continue the loop to check whether there is some color inec.Thanks to @nrnavaneet, who worked on this in #30299, and which this PR is based on.
Closes #30298
PR checklist
Plotting related features are demonstrated in an exampleNew Features and API Changes are noted with a directive and release noteDocumentation complies with general and docstring guidelines