Two new optional inputs, provisioner_tag and ignore_lockfile, to enhance the configurability of the template push process
#14
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the Coder template push action by adding two new optional configuration inputs: provisioner_tag for template version identification in the UI and ignore_lockfile for handling missing Terraform lock files.
- Added
provisioner_taginput with default value "-" to tag template versions - Added
ignore_lockfileinput with default value "false" to suppress lockfile warnings - Updated shell script to conditionally include the new flags in the push command
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| action.yaml | Added two new input definitions and corresponding environment variables |
| push_template.sh | Implemented conditional logic to include new command-line flags based on environment variables |
| provisioner_tag: | ||
| description: "Add provisioner tag to the template, useful for identifying the template version in the Coder UI" | ||
| required: false | ||
| default: "-" |
There was a problem hiding this comment.
The default value "-" for provisioner_tag is unclear and may cause confusion. Consider using an empty string or a more descriptive default value, or make it truly optional without a default.
| default: "-" | |
| default: "" |
Copilot uses AI. Check for mistakes.
| @@ -19,6 +19,11 @@ if [ -n "${CODER_TEMPLATE_MESSAGE}" ]; then | |||
| push_command+=" --message \"${CODER_TEMPLATE_MESSAGE}\"" | |||
| fi | |||
|
|
|||
| # Add provisioner tag to the push command if specified | |||
| if [ -n "${CODER_PROVISIONER_TAG}" ]; then | |||
There was a problem hiding this comment.
The provisioner tag value is always passed when the environment variable is set, even if it's the default "-" value. Consider checking if the value is meaningful (not "-") before adding it to the command.
| if [ -n "${CODER_PROVISIONER_TAG}" ]; then | |
| if [ -n "${CODER_PROVISIONER_TAG}" ] && [ "${CODER_PROVISIONER_TAG}" != "-" ]; then |
Copilot uses AI. Check for mistakes.
This pull request introduces two new optional inputs,
provisioner_tagandignore_lockfile, to enhance the configurability of the template push process. These inputs are integrated into the action's environment variables and thepush_template.shscript to support additional functionality.Enhancements to
action.yamlinputs:provisioner_taginput to allow specifying a provisioner tag for identifying the template version in the Coder UI. Default value is"-".ignore_lockfileinput to enable ignoring warnings about the absence of a.terraform.lock.hclfile. Default value is"false".Updates to the
push_template.shscript:provisioner_taginput into the push command to include a--provisioner-tagoption if specified.ignore_lockfileinput into the push command to add a--ignore-lockfile=trueflag when enabled.