Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@llvm/pr-subscribers-lldb

Author: None (b10902118)

diff --git a/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.h b/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.h
index 15b46609c286b..420e866dbd635 100644
--- a/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.h
+++ b/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.h
@@ -109,7 +109,6 @@ class NativeRegisterContextLinux_arm : public NativeRegisterContextLinux {
                            // occurred.
     lldb::addr_t real_addr; // Address value that should cause target to stop.
     uint32_t control;       // Breakpoint/watchpoint control value.
-    uint32_t refcount;      // Serves as enable/disable and reference counter.
   };
 
   struct DREG m_hbr_regs[16]; // Arm native linux hardware breakpoints

@DavidSpickett
For #147198 (comment)

Please setup your Github email settings according to https://llvm.org/docs/DeveloperPolicy.html#email-addresses.

It does generate a "co-authored by" using what I assume is a valid email address, but the commit email is still a github noreply. A co author tag might be ok, but the policy does not say so I'm being cautious here.

Once that's fixed we can merge this.

Sorry about that. Both are not valid though. I didn't know the role of email in git until you mention this...

I have disabled private email on github and reconfigured my git. Should I amend and force push?

Once that's fixed we can merge this.

Fixed with git commit --amend --reset-author --no-edit. Learned a lesson. Thanks!

Well as llvm is setup, all the metadata of the final commit comes from GitHub in fact. The title and message come from the PR, the author details from your Github settings, etc.

Other projects may not be set up like this though, so a good thing to learn regardless.

Everything looks good.

@b10902118 Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!