[ORC] Add automatic shared library resolver for unresolved symbols. #148410
+2,479
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can test this locally with the following command:git-clang-format --diff HEAD~1 HEAD --extensions cpp,h -- llvm/include/llvm/ExecutionEngine/Orc/Shared/SymbolFilter.h llvm/include/llvm/ExecutionEngine/Orc/TargetProcess/LibraryResolver.h llvm/include/llvm/ExecutionEngine/Orc/TargetProcess/LibraryScanner.h llvm/lib/ExecutionEngine/Orc/TargetProcess/LibraryResolver.cpp llvm/lib/ExecutionEngine/Orc/TargetProcess/LibraryScanner.cppView the diff from clang-format here.diff --git a/llvm/lib/ExecutionEngine/Orc/TargetProcess/LibraryScanner.cpp b/llvm/lib/ExecutionEngine/Orc/TargetProcess/LibraryScanner.cpp
index 2339c63c2..9aa449f7a 100644
--- a/llvm/lib/ExecutionEngine/Orc/TargetProcess/LibraryScanner.cpp
+++ b/llvm/lib/ExecutionEngine/Orc/TargetProcess/LibraryScanner.cpp
@@ -311,7 +311,7 @@ mode_t PathResolver::lstatCached(StringRef path) {
return *cache;
// Not cached: perform lstat and store
- struct stat buf {};
+ struct stat buf{};
mode_t st_mode = (lstat(path.str().c_str(), &buf) == -1) ? 0 : buf.st_mode;
m_cache->insert_lstat(path, st_mode);
|
|
@SahilPatidar, what is still required for this PR to make it ready for review? |
|
Done. We'll improve it based on the review. I had added async locally before, but it would be better if lhames reviews it so we can get a better idea of how to improve it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a redesigned and rebuilt Cling-based auto-loading workaround, which enables scanning libraries and searching for unresolved symbols within the scanned libraries.