Skip to content

config/app.php timezone should be configurable based on .env var APP_TIMEZONE #6622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

developerByDay
Copy link

Unless we override the timezone in config/app.php in our project directory, UTC in not configurable and becomes the APP_TIMEZONE. Which in our case, caused many problems. Since we use expirable tokens across multiple applications, it caused serious issues in our native APIs.

…ctory, UTC in not configurable and becomes the APP_TIMEZONE. Which in our case, caused many problems. Since we use expirable tokens across multiple applications, it caused serious issues in our native APIs.
Copy link
Member

@GrahamCampbell GrahamCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change has been proposed before, and is not wanted to be included by default. Changing the time-zone on the server side is almost always the wrong answer. There are rare exceptions, but UTC time-zone is very strongly recommended. Moreover, changing per environment is even more rare, still. You can still edit this config file in your own project if you have a use case where you feel this is the best option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants