[12.x] Fix typehint for VerifyEmail::toMailUsing()
#56454
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaedrich
reviewed
Jul 27, 2025
| @@ -21,7 +21,7 @@ class VerifyEmail extends Notification | |||
| /** | |||
| * The callback that should be used to build the mail message. | |||
| * | |||
| * @var \Closure|null | |||
| * @var (\Closure(mixed, string): \Illuminate\Notifications\Messages\MailMessage|\Illuminate\Contracts\Mail\Mailable)|null | |||
There was a problem hiding this comment.
Are you sure that's the correct return type as toMail() only ever returns \Illuminate\Notifications\Messages\MailMessage?
framework/src/Illuminate/Auth/Notifications/VerifyEmail.php
Lines 39 to 54 in 2bc2b7e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the toMailUsing method in the VerifyEmail notification only documents the $callback parameter as a generic \Closure without specifying the expected input parameters or return type.
This PR improves the docblock by adding a return type declaration to the callback, specifying that it should return either an instance of MailMessage or a Mailable.
This detailed typehint helps IDEs and static analysis tools (like PHPStan or Psalm) better understand the expected usage, improving developer experience and code quality.