Fix incorrect docblock for custom builder resolvers #56392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes laravel#56152 which was caused by the incorrect parameters being used for a more specific type hint docblock merged in laravel#55687. This currently causes issues with projects that use static analysis and make use of the $builder->blueprintResolver() method to resolve custom blueprints. Example below: ------ ---------------------------------------------------------------------------------------------------------- Line Database/DatabaseServiceProvider.php ------ ---------------------------------------------------------------------------------------------------------- :109 Parameter laravel#1 $connection of class Winter\Storm\Database\Schema\Blueprint constructor expects Illuminate\Database\Connection, string given. 🪪 argument.type :109 Parameter laravel#2 $table of class Winter\Storm\Database\Schema\Blueprint constructor expects string, Closure given. 🪪 argument.type :109 Parameter laravel#3 $callback of class Winter\Storm\Database\Schema\Blueprint constructor expects Closure|null, string given. 🪪 argument.type ------ ----------------------------------------------------------------------------------------------------------
LukeTowers
commented
Jul 23, 2025
|
@crynobone I've submitted a PR to fix #56152 as requested. |
LukeTowers
commented
Jul 23, 2025
LukeTowers
added a commit
to wintercms/storm
that referenced
this pull request
Jul 23, 2025
Can remove once laravel/framework#56392 is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56152 which was caused by the incorrect parameters being used for a more specific type hint docblock merged in #55687.
This currently causes issues with projects that use static analysis and make use of the $builder->blueprintResolver() method to resolve custom blueprints.
See https://github.com/LukeTowers/framework/blob/patch-1/src/Illuminate/Database/Schema/Builder.php#L621-L637 for the proof of the corrected typehints.
Example below: