Fix segfault in mark_locations_array #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rst created thread); allows program stack to be properly examined
|
Bravo! |
maxdjohnson
added a commit
that referenced
this pull request
Nov 24, 2012
Fix segfault in mark_locations_array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a segfault in mark_locations_array.
This segfault was a result of treating one of the pthread's stacks as the stack of the thread starting garbage collection. When mark_current_machine_context saves the current machine state into a jump buffer, it was using the wrong stack, causing mark_locations_array to be called with weird arguments which eventually led to a segfault.
Perhaps predictably, shit still does not work, but garbage collection will now complete a single pass on gc-test/simple.rb.