fix dtypes not used on csv parse #657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the issue where the configured dtypes were not being applied during CSV parsing, resulting in unwanted conversion of certain values such as leading zeros.
- Updated tests in both Node and browser environments to validate the preservation of leading zeros when dtype is set to "string".
- Modified the CSV parsing logic in both Node and browser implementations to conditionally disable dynamic typing when dtypes include "string", and explicitly set the delimiter.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/danfojs-node/test/io/csv.reader.test.ts | Added tests to ensure correct behavior when using the "string" dtype. |
| src/danfojs-browser/tests/io/csv.reader.test.js | Added corresponding tests for browser CSV parsing. |
| src/danfojs-base/io/node/io.csv.ts | Updated CSV parsing logic to conditionally disable dynamic typing and set delimiter. |
| src/danfojs-base/io/browser/io.csv.ts | Updated CSV parsing logic for browser to conditionally disable dynamic typing and set delimiter. |
Comments suppressed due to low confidence (1)
src/danfojs-node/test/io/csv.reader.test.ts:136
- [nitpick] Consider refactoring the file cleanup logic by using a finally block instead of duplicating fs.unlinkSync in both the try and catch blocks to ensure consistent cleanup.
fs.unlinkSync(filePath);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.