Skip to content

fix(src):fix some ts error hint #2134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 6.x
Choose a base branch
from

Conversation

JayMeDotDot
Copy link

src/Collection.ts
I changed generic type T to unknown; otherwise, ts will lint a Type '(Iterable<T> | ArrayLike<T>) & IndexedCollectionImpl<unknown>' is not assignable to type 'IndexedCollectionImpl<T> error message.

src/predicates/isKeyed.ts
You left a to-do, so I changed it.

src/utils/mixin.ts
PropertyKey has a type of number | string | symbol.
I don't know why Object.getOwnPropertySymbols needs to be an assertion.
Removing it, the ESLint error message automatically disappears.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant