-
-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Add documentation for new valve in homematicip_cloud #40076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds documentation for a new valve device type to the HomeMatic IP Cloud integration. The change supports the addition of watering valve functionality that was implemented in the corresponding Home Assistant core pull request.
- Adds valve as a supported platform category and device type
- Documents the specific ELV-SH-WSM watering valve model
@@ -207,6 +210,9 @@ Currently, the **HmIP-DLD** can only be used in Home Assistant without a PIN. En | |||
- Switch Actuator for DIN rail mount – 1x channels (*HMIP-DRSI1*) | |||
- Switch Actuator - 2x channels (*HmIP-BS2*) | |||
|
|||
- homematicip_cloud.valve | |||
- Watering Valve (*ELV-SH-WSM*) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The device listing format is inconsistent with other entries. Based on the established pattern in the file, this should follow the format 'Device Name (Model-Number)' where the device name describes the function, not just 'Watering Valve'. Consider using a more descriptive name like 'Smart Watering Valve' or following the manufacturer's official product name.
Copilot uses AI. Check for mistakes.
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @hahn-th 👍
Proposed change
Add valve to documentation
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.