Skip to content

Add documentation for new valve in homematicip_cloud #40076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2025

Conversation

hahn-th
Copy link
Contributor

@hahn-th hahn-th commented Jul 20, 2025

Proposed change

Add valve to documentation

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@Copilot Copilot AI review requested due to automatic review settings July 20, 2025 07:30
@home-assistant home-assistant bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels Jul 20, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds documentation for a new valve device type to the HomeMatic IP Cloud integration. The change supports the addition of watering valve functionality that was implemented in the corresponding Home Assistant core pull request.

  • Adds valve as a supported platform category and device type
  • Documents the specific ELV-SH-WSM watering valve model

@@ -207,6 +210,9 @@ Currently, the **HmIP-DLD** can only be used in Home Assistant without a PIN. En
- Switch Actuator for DIN rail mount – 1x channels (*HMIP-DRSI1*)
- Switch Actuator - 2x channels (*HmIP-BS2*)

- homematicip_cloud.valve
- Watering Valve (*ELV-SH-WSM*)
Copy link
Preview

Copilot AI Jul 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The device listing format is inconsistent with other entries. Based on the established pattern in the file, this should follow the format 'Device Name (Model-Number)' where the device name describes the function, not just 'Watering Valve'. Consider using a more descriptive name like 'Smart Watering Valve' or following the manufacturer's official product name.

Copilot uses AI. Check for mistakes.

Copy link

netlify bot commented Jul 20, 2025

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 2d06392
🔍 Latest deploy log https://app.netlify.com/projects/home-assistant-docs/deploys/687deb20a36dec00088cf059
😎 Deploy Preview https://deploy-preview-40076--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @hahn-th 👍

@c0ffeeca7 c0ffeeca7 added the awaits-parent Awaits the merge of an parent PR label Jul 22, 2025
@home-assistant home-assistant bot added the parent-merged The parent PR has been merged already label Jul 22, 2025
@joostlek joostlek merged commit e276a2f into home-assistant:next Jul 22, 2025
7 checks passed
@home-assistant home-assistant bot removed awaits-parent Awaits the merge of an parent PR parent-merged The parent PR has been merged already labels Jul 22, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jul 23, 2025
@hahn-th hahn-th deleted the patch-1 branch July 26, 2025 08:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
has-parent This PR has a parent PR in another repo next This PR goes into the next branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants