-
-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Add Ubiquiti UISP airOS #40057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ubiquiti UISP airOS #40057
Conversation
It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the |
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
||
This integration exposes the following sensor entities for your airOS devices: | ||
|
||
### Network Role |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the titles in this sections: are these the names of the sensors as shown in the UI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, style copied from Unfi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Not sure what I was thinking when reviewing the Unifi headers... I actually prefer the list style, especially if there are more entities to come. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coming from https://www.home-assistant.io/integrations/plugwise/ I preferred the list style, but thought to keep it somewhat in line with the rest of the Ubiquiti family :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I rewrite them or are you already committing things? (Let's not clash and waste time)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense to keep it consistent. Can't argue with that :-D
Tnx for the (re)structur(ing) |
Note: home-assistant/core#148989 (comment) regarding naming |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @CoMPaTech 👍
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Proposed change
Introduce Ubiquiti airOS integration for monitoring wireless bridges interconnecting locations.
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.