-
-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Some textual changes to Music Assistant docs #39814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR corrects a formatting typo and updates the documentation by removing an outdated availability note from the Favorite button section.
- Fixed a leading dash typo on the Favorite button paragraph
- Added spacing adjustments around the list
- Removed the sentence on button entity availability
Comments suppressed due to low confidence (2)
source/_integrations/music_assistant.markdown:56
- Remove the trailing whitespace at the end of this line to prevent unintended Markdown line breaks.
The Music Assistant integration creates a button entity for each player to favorite the current song. Pressing this button (manually or by automation) adds the current song to your Music Assistant favorites. This works for local playing songs and tracks from streaming providers. It also works with remote content such as Spotify Connect, AirPlay, or a radio station, as long as the external source provides an artist and title combination (and optionally the album).
📝 WalkthroughWalkthroughThe documentation for the Music Assistant integration was updated to rename the "Media player" platform link to "Media player entities," add two blank lines after the "Button" platform entry in the supported platforms list, and remove a sentence about the availability of the "Favorite current song button" feature. No code or functional changes were made. Changes
Sequence Diagram(s)No sequence diagram generated as the changes are limited to documentation formatting and minor content edits. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
source/_integrations/music_assistant.markdown (2)
25-26
: Remove the extra blank line to satisfy MD012.Two consecutive blank lines break the Markdown-lint rule
no-multiple-blanks
and needlessly stretch the rendered list.- - [Button](#favorite-current-song-button) - + - [Button](#favorite-current-song-button)
56-56
: Trim the trailing space at EOL to satisfy MD009.There’s an orphan space at the end of the line which triggers the
no-trailing-spaces
rule.-…artist and title combination (and optionally the album).␠ +…artist and title combination (and optionally the album).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
source/_integrations/music_assistant.markdown
(2 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/music_assistant.markdown
[style] ~26-~26: Consider removing “of” to be more concise
Context: ...utton](#favorite-current-song-button) All of the Home Assistant [Media Player Control Ac...
(ALL_OF_THE)
🪛 markdownlint-cli2 (0.17.2)
source/_integrations/music_assistant.markdown
26-26: Multiple consecutive blank lines
Expected: 1; Actual: 2
(MD012, no-multiple-blanks)
56-56: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
source/_integrations/music_assistant.markdown (2)
25-26
: Remove the extra blank line to satisfy MD012
markdownlint
flags two consecutive blank lines after the list. One is enough:-25 - -26 +25
56-56
: Trim trailing whitespace (MD009)There is a single space at the end of this line; removing it keeps the file tidy and avoids lint warnings:
-The Music Assistant integration creates a button entity for each player to favorite the current song. Pressing this button (manually or by automation) adds the current song to your Music Assistant favorites. This works for local playing songs and tracks from streaming providers. It also works with remote content such as Spotify Connect, AirPlay, or a radio station, as long as the external source provides an artist and title combination (and optionally the album).␠ +The Music Assistant integration creates a button entity for each player to favorite the current song. Pressing this button (manually or by automation) adds the current song to your Music Assistant favorites. This works for local playing songs and tracks from streaming providers. It also works with remote content such as Spotify Connect, AirPlay, or a radio station, as long as the external source provides an artist and title combination (and optionally the album).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
source/_integrations/music_assistant.markdown
(2 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/music_assistant.markdown
[style] ~26-~26: Consider removing “of” to be more concise
Context: ...utton](#favorite-current-song-button) All of the Home Assistant [Media Player Control Ac...
(ALL_OF_THE)
🪛 markdownlint-cli2 (0.17.2)
source/_integrations/music_assistant.markdown
26-26: Multiple consecutive blank lines
Expected: 1; Actual: 2
(MD012, no-multiple-blanks)
56-56: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (1)
source/_integrations/music_assistant.markdown (1)
23-23
: Anchor looks correct – no action neededThe updated link now targets
#media-player-entities
, which matches the slug automatically generated by the heading on line 50.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @marcelveldt 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
source/_integrations/music_assistant.markdown (2)
23-26
: Remove extra blank line & sync link text with the section header.
- Two consecutive blank lines violate
MD012
(only one blank line expected).- The display text
Media player
no longer matches the section title### Media player entities
; keeping them identical improves clarity and avoids surprising readers.- - [Media player](#media-player-entities) - - [Button](#favorite-current-song-button) - - + - [Media player entities](#media-player-entities) + - [Button](#favorite-current-song-button) +
56-56
: Delete trailing whitespace.Line 56 ends with an unnecessary space, tripping
MD009
. Removing it keeps the docs lint-clean.-… (and optionally the album). +… (and optionally the album).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
source/_integrations/music_assistant.markdown
(2 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/music_assistant.markdown
[style] ~26-~26: Consider removing “of” to be more concise
Context: ...utton](#favorite-current-song-button) All of the Home Assistant [Media Player Control Ac...
(ALL_OF_THE)
🪛 markdownlint-cli2 (0.17.2)
source/_integrations/music_assistant.markdown
26-26: Multiple consecutive blank lines
Expected: 1; Actual: 2
(MD012, no-multiple-blanks)
56-56: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
Proposed change
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit