xds: refactor xdsresource.Endpoint to add resolver.Endpoint (gRFC A81) #8750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8750 +/- ##
==========================================
+ Coverage 83.28% 83.36% +0.07%
==========================================
Files 418 418
Lines 32367 32496 +129
==========================================
+ Hits 26958 27091 +133
+ Misses 4034 4022 -12
- Partials 1375 1383 +8
🚀 New features to boost your workflow:
|
easwars
reviewed
Dec 8, 2025
easwars
previously approved these changes
Dec 10, 2025
| // setHostname returns a copy of the given endpoint with hostname added | ||
| // as an attribute. | ||
| func setHostname(endpoint resolver.Endpoint, hostname string) resolver.Endpoint { | ||
| // Only set if non-empty; xds_cluster_impl uses this to trigger :authority rewriting. |
Contributor
There was a problem hiding this comment.
Please wrap comment sentences at 80-cols. See: go/go-style/decisions#comment-line-length
Comment on lines
576
to
578
| ResolverEndpoint: resolver.Endpoint{ | ||
| Addresses: []resolver.Address{{Addr: "addr-2-2"}}, | ||
| }, |
Contributor
There was a problem hiding this comment.
Nit: There are still a few more places in this file where the literal struct could be specified in a single line.
easwars
reviewed
Dec 10, 2025
| // Create a copy of endpoint.ResolverEndpoint to avoid race. | ||
| resolverEndpoint := endpoint.ResolverEndpoint | ||
| resolverEndpoint.Addresses = make([]resolver.Address, len(endpoint.ResolverEndpoint.Addresses)) | ||
| copy(resolverEndpoint.Addresses, endpoint.ResolverEndpoint.Addresses) |
Contributor
There was a problem hiding this comment.
Hmm.. actually hold on. Copying a slice of resolver.Address will create a new slice with new resolver.Address instances, but they might still be referring to the same attributes. We need to discuss this a little bit more.
We need more discussion on safely copying resolver.Endpoint and resolver.Address structs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the internal
xdsresource.Endpointstruct to contain aresolver.Endpointinstead of a[]stringto store the list of addresses associated with the endpoint gRFC A81. This change standardizes how backend information is stored and ensures that attributes (such as Hostname) are correctly associated with the endpoint hierarchy.Key Changes:
Struct Update:
xdsresource.Endpointnow includes aResolverEndpointfield (of typeresolver.Endpoint) to store addresses and attributes. Remove the existingAddressfield (of type[]string) and store address as aresolver.Endpointfield.Attribute Handling:
SetHostnameandGetHostnamehelpers to manage hostname metadata withinresolver.Endpoint.Attributes.Parsing Logic:
parseEndpointsinunmarshal_eds.goto correctly populate theresolver.Endpointobject.RELEASE NOTES: N/A