Change compute services UpdateOpts fields ForceDown to pointer #3472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayrus
previously approved these changes
Jul 21, 2025
This follows the same pattern as in the rest of the code and uses a pointer to fix gophercloud#3471 and allow the caller to unset a prior ForceDown. This unfortunately changes though the API in a breaking way.
kayrus
approved these changes
Jul 21, 2025
|
LGTM, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows the same pattern as in the rest of the code and uses a pointer to fix #3471 and allow the caller to unset a prior ForceDown.
This unfortunately changes though the API in a breaking way.
Fixes #3471
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/services.py#L473-L479