Skip to content

Switch to a version of gocovmerge compatible with go 1.22 #3470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2025

Conversation

kayrus
Copy link
Contributor

@kayrus kayrus commented Jul 18, 2025

The original gocovmerge repository [1] has not seen a commit in 9 years and should be considered unmaintained.

Switch to fork has a go.mod pinned to go 1.22. Please review the diff [2] between the two repos to check if it's safe to use in gophercloud.

[1] https://github.com/wadey/gocovmerge
[2] wadey/gocovmerge@master...alexfalkowski:gocovmerge:v1.4.0

This is a cherry-pick of the #3325

The original `gocovmerge` repository [1] has not seen a commit in 9 years
and should be considered unmaintained.

Switch to fork has a go.mod pinned to go 1.22. Please review the diff [2]
between the two repos to check if it's safe to use in gophercloud.

[1] https://github.com/wadey/gocovmerge
[2] wadey/gocovmerge@master...alexfalkowski:gocovmerge:v1.4.0
@github-actions github-actions bot added semver:patch No API change backport-v2 This PR will be backported to v2 edit:actions This PR updates GitHub Actions code edit:testinfra This PR updates testing infrastructure code labels Jul 18, 2025
@coveralls
Copy link

Coverage Status

coverage: 63.735%. remained the same
when pulling b9132fc on kayrus:gocovmerge
into 0a760af on gophercloud:main.

@kayrus kayrus merged commit 9c6475a into gophercloud:main Jul 19, 2025
16 checks passed
@kayrus kayrus deleted the gocovmerge branch July 19, 2025 17:11
Copy link

Failed to backport PR to v2 branch. See logs for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v2 This PR will be backported to v2 edit:actions This PR updates GitHub Actions code edit:testinfra This PR updates testing infrastructure code semver:patch No API change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants