Skip to content

core: pass context to the provider.EndpointLocator func #3442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2025
Merged

core: pass context to the provider.EndpointLocator func #3442

merged 1 commit into from
Jul 9, 2025

Conversation

kayrus
Copy link
Contributor

@kayrus kayrus commented Jun 26, 2025

Fixes #3441

@kayrus kayrus requested a review from stephenfin June 26, 2025 08:26
@github-actions github-actions bot added edit:openstack This PR updates common OpenStack code edit:gophercloud This PR updates common Gophercloud code edit:testinfra This PR updates testing infrastructure code semver:major Breaking change labels Jun 26, 2025
@kayrus kayrus force-pushed the endpoint-locator-context branch from e8e5312 to 330dbcf Compare June 26, 2025 08:36
@github-actions github-actions bot added the edit:identity This PR updates identity code label Jun 26, 2025
@kayrus kayrus force-pushed the endpoint-locator-context branch from 330dbcf to 2595acd Compare June 26, 2025 08:43
@coveralls
Copy link

coveralls commented Jun 26, 2025 •
edited
Loading

Coverage Status

coverage: 63.702%. remained the same
when pulling 2595acd on kayrus:endpoint-locator-context
into c3046e0 on gophercloud:main.

@github-actions github-actions bot added edit:config This PR updates config code edit:common This PR updates common code edit:orchestration This PR updates orchestration code edit:compute This PR updates compute code edit:containerinfra This PR updates containerinfra code labels Jun 26, 2025
@kayrus
Copy link
Contributor Author

kayrus commented Jul 1, 2025

@stephenfin @pierreprinetti @mandre kindly ping

@kayrus
Copy link
Contributor Author

kayrus commented Jul 3, 2025

Since not all tests are green, I'd like to receive one more approval before the merge

@stephenfin
Copy link
Contributor

The messaging failures are expected since we are not handling paths as we should. I'm looking into this. The ironic failures are also known: @Sharpz7 is looking into it. The Octavia failures are new though. I'll look at this too.

@kayrus kayrus merged commit 7ed51ce into gophercloud:main Jul 9, 2025
78 of 82 checks passed
@kayrus kayrus deleted the endpoint-locator-context branch July 9, 2025 13:49
@kayrus kayrus mentioned this pull request Jul 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenfin stephenfin stephenfin approved these changes

Assignees
No one assigned
Labels
edit:common This PR updates common code edit:compute This PR updates compute code edit:config This PR updates config code edit:containerinfra This PR updates containerinfra code edit:gophercloud This PR updates common Gophercloud code edit:identity This PR updates identity code edit:openstack This PR updates common OpenStack code edit:orchestration This PR updates orchestration code edit:testinfra This PR updates testing infrastructure code semver:major Breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

core: endpoint locator doesn't use active context to resolve microversions
3 participants
@kayrus @coveralls @stephenfin