Fix security group rule "any protocol" #3162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this patch, Gophercloud attempted to create a security group rule that would be applied regardless of the protocol by passing the literal `"any"` as the rule protocol. Despite being correct according to [the documentation][1], Neutron rejects the value `"any"` with an HTTP status code of `400 Bad Request`. This change replaces the value of `ProtocolAny` to be the empty string `""`, which has the effect of creating a rule that applies to any protocol. cf: [Neutron bug 2074056][2] [1]: https://docs.openstack.org/api-ref/network/v2/#create-security-group-rule [2]: https://bugs.launchpad.net/neutron/+bug/2074056
kayrus
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3157
Before this patch, Gophercloud attempted to create a security group rule that would be applied regardless of the protocol by passing the literal
"any"as the rule protocol.Despite being correct according to the documentation, Neutron rejects the value
"any"with an HTTP status code of400 Bad Request.This change replaces the value of
ProtocolAnyto be the empty string"", which has the effect of creating a rule that applies to any protocol.cf: Neutron bug 2074056
Fixes #2442