clang: Add CallableCustomMethodPointerBase virtual destructor #1275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

dsnopek merged 1 commit into godotengine:master from capnm:fix-clang-virt_destructor-warning

Oct 19, 2023

Contributor

capnm commented Oct 19, 2023

Fixes #1272

clang++ (debian v16/v17) warning: destructor called on 'godot::CallableCustomMethodPointerBase' that is abstract but has non-virtual destructor [-Wdelete-abstract-non-virtual-dtor]


          clang: Add CallableCustomMethodPointerBase virtual destructor

a926b96

Fixes godotengine#1272
+ clang++ (debian v16/v17) warning:
	destructor called on
	'godot::CallableCustomMethodPointerBase' that is abstract but has non-virtual destructor
	[-Wdelete-abstract-non-virtual-dtor]

capnm requested a review from a team as a code owner

October 19, 2023 10:25

dsnopek added the bug label

dsnopek added this to the 4.2 milestone

dsnopek approved these changes

View reviewed changes

Collaborator

dsnopek left a comment

Thanks! This looks good to me :-)

dsnopek merged commit 7a3cfe8 into godotengine:master

Collaborator

dsnopek commented Oct 19, 2023

Congrats on your first merged PR! 🎉

capnm deleted the fix-clang-virt_destructor-warning branch

October 19, 2023 20:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug