Skip to content

Fix formatting of compatibility_minimum examples #1226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dsnopek merged 1 commit into from
Aug 31, 2023
Merged

Fix formatting of compatibility_minimum examples #1226

dsnopek merged 1 commit into from
Aug 31, 2023

Conversation

@AThousandShips
Copy link
Member

@AThousandShips AThousandShips commented Aug 31, 2023

@AThousandShips AThousandShips added bug This has been identified as a bug cherrypick:4.1 labels Aug 31, 2023
@AThousandShips AThousandShips added this to the 4.2 milestone Aug 31, 2023
@AThousandShips AThousandShips requested a review from a team as a code owner August 31, 2023 10:15
@AThousandShips AThousandShips changed the title Ensure compatibility_minimum is parsed correctly Ensure compatibility_minimum is correctly formatted Aug 31, 2023
@AThousandShips
Fix formatting of compatibility_minimum examples
b3596a1 
Without quotes the values is parsed as a float, breaking in various
cases.
@AThousandShips AThousandShips changed the title Ensure compatibility_minimum is correctly formatted Fix formatting of compatibility_minimum examples Aug 31, 2023
dsnopek
dsnopek approved these changes Aug 31, 2023
View reviewed changes
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dsnopek dsnopek merged commit 9ada706 into godotengine:master Aug 31, 2023
@AThousandShips
Copy link
Member Author

AThousandShips commented Aug 31, 2023

Thank you!

@AThousandShips AThousandShips deleted the version_str branch August 31, 2023 13:18
@AThousandShips AThousandShips mentioned this pull request Aug 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsnopek dsnopek dsnopek approved these changes

Assignees

No one assigned

Labels

bug This has been identified as a bug documentation

Projects

None yet

Milestone

4.2

Development

Successfully merging this pull request may close these issues.

2 participants

@AThousandShips @dsnopek