Ensure that PtrToArg specializations for native structs are used #1214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paddy-exe
approved these changes
Sep 8, 2023
Contributor
paddy-exe
left a comment
There was a problem hiding this comment.
Discussed at GExtension Meeting.
Looks good to me 👍🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1207
This changes
binding_generator.py, so that rather than forward declaring native structures (which will have their own specialization forPtrToArg<>), it will always make sure to include the header.It also adds a
static_assert()to thePtrToArg<>specialization forObject's in order to ensure that it isn't ever used with a type that doesn't descend fromObject. Using the MRP from #1207, if I comment out the fix inbinding_generator.pythen it will correctly fail to compile.